Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relay compilation and ensure future compilations in builds #2182

Merged
merged 4 commits into from
Oct 19, 2022

Conversation

benjaminpkane
Copy link
Contributor

Fixes relay compilation in @fiftyone/core and ensures future breaking changes will be caught in workflows via the yarn build script in @fiftyone/app.

Also removes unused prettier code in the app and adds generated files created by relay to the .prettierignore which I find more convenient than compiling and reformatting every time via pre-commit.

@benjaminpkane benjaminpkane added bug Bug fixes app Issues related to App features labels Oct 17, 2022
@benjaminpkane benjaminpkane self-assigned this Oct 17, 2022
Copy link
Contributor

@ritch ritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminpkane benjaminpkane merged commit 6d00ebf into develop Oct 19, 2022
@benjaminpkane benjaminpkane deleted the bugfix/relay branch October 19, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Issues related to App features bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants