Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimizing ordered select implementation #2227

Merged
merged 2 commits into from
Nov 5, 2022
Merged

Optimizing ordered select implementation #2227

merged 2 commits into from
Nov 5, 2022

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Nov 3, 2022

In the typical case where the number of selected IDs is small compared to the number of total documents, this implementation of ordered select(), select_by() and select_groups() should be more efficient. $match first, then $set.

@brimoor brimoor added the enhancement Code enhancement label Nov 3, 2022
@brimoor brimoor requested a review from a team November 3, 2022 16:50
@brimoor brimoor self-assigned this Nov 3, 2022
benjaminpkane
benjaminpkane approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brimoor brimoor merged commit ae5ac5a into develop Nov 5, 2022
@brimoor brimoor deleted the optimize-select branch November 5, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminpkane benjaminpkane benjaminpkane approved these changes

Assignees

@brimoor brimoor

Labels
enhancement Code enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brimoor @benjaminpkane