Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration using removed pymongo method #2240

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

j053y
Copy link
Contributor

@j053y j053y commented Nov 4, 2022

migration 0.6.2. collection_names -> list_collection_names

@j053y j053y requested a review from brimoor November 4, 2022 17:02
@j053y j053y self-assigned this Nov 4, 2022
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j053y I believe the 404.html file that is deleted by this PR needs to exist.

I assume this wasn't intentional on your part (empty files and git don't get along well). @benjaminpkane can elaborate if needed

@j053y
Copy link
Contributor Author

j053y commented Nov 4, 2022

@brimoor Just noticed that as well (it was in fact an accident). Added back in.

@j053y j053y requested a review from brimoor November 4, 2022 17:20
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brimoor brimoor merged commit 515db1d into develop Nov 4, 2022
@brimoor brimoor deleted the bugfix/migration-failing-withupgraded-pymongo branch November 4, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants