Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update color scheme on theme update #2263

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

imanjra
Copy link
Contributor

@imanjra imanjra commented Nov 8, 2022

What changes are proposed in this pull request?

PR fixes an issue where color scheme is not updated on theme change from session

How is this patch tested? If it is not, please explain why.

Manually tested by toggling theme from session

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@imanjra imanjra marked this pull request as draft November 8, 2022 22:26
@imanjra imanjra marked this pull request as ready for review November 8, 2022 22:43
@benjaminpkane benjaminpkane merged commit f0a0c7d into develop Nov 8, 2022
@benjaminpkane benjaminpkane deleted the bugfix/session-theme-change branch November 8, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants