Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permission for custom color settings #2888

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

manivoxel51
Copy link
Contributor

What changes are proposed in this pull request?

pass canEditCustomColors for permission in teams usage

How is this patch tested? If it is not, please explain why.

(Details)

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06 🎉

Comparison is base (e2fa793) 61.90% compared to head (3311694) 61.97%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2888      +/-   ##
===========================================
+ Coverage    61.90%   61.97%   +0.06%     
===========================================
  Files          259      259              
  Lines        43730    43808      +78     
  Branches       350      350              
===========================================
+ Hits         27072    27150      +78     
  Misses       16658    16658              
Flag Coverage Δ
app 48.62% <100.00%> (+0.01%) ⬆️
python 99.42% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/packages/looker/src/worker/index.ts 100.00% <100.00%> (ø)
app/packages/state/src/recoil/atoms.ts 89.57% <100.00%> (+0.14%) ⬆️
tests/unittests/dataset_tests.py 99.83% <100.00%> (+<0.01%) ⬆️
tests/unittests/group_tests.py 99.60% <100.00%> (+0.01%) ⬆️
tests/unittests/view_tests.py 99.86% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@manivoxel51 manivoxel51 merged commit 3866b6e into develop Apr 7, 2023
@manivoxel51 manivoxel51 deleted the mani/permission-color-settings branch April 7, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants