CVAT v2.4 support #2903
Merged
CVAT v2.4 support #2903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests passing with cvat v2.4 but backwards compat with v2.3 still todo
added branching to support cvat server versions < v2.4
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2903 +/- ##
===========================================
+ Coverage 62.05% 62.20% +0.14%
===========================================
Files 259 250 -9
Lines 43974 45488 +1514
Branches 350 319 -31
===========================================
+ Hits 27288 28294 +1006
- Misses 16686 17194 +508
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Merged
* merge _get_paginated_results_2, parse versions * version * remove print * fix v2.4 login issue * trigger job id check less frequently * nit
to avoid hitting limit on number of open filehandles
|
@brimoor merged @ehofesmann 's changes and added a small change per @renanwille #2959 (comment) Checked in |
ehofesmann
approved these changes
May 9, 2023
brimoor
approved these changes
May 9, 2023
lanzhenw
pushed a commit
that referenced
this pull request
May 10, 2023
* wip: tests passing with cvat v2.4, backwards compat with v2.3 todo * wip: added branching to support cvat server versions < v2.4 * CVAT v2.4 updates (#2959) * merge _get_paginated_results_2, parse versions * version * remove print * fix v2.4 login issue * trigger job id check less frequently * nit * Read file contents before passing to requests.post to avoid hitting limit on number of open filehandles * linting * more linting --------- Co-authored-by: Eric Hofesmann <[email protected]> Co-authored-by: brimoor <[email protected]>
|
When will this be included in a release? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
CVAT integration: support CVAT server v2.4
How is this patch tested? If it is not, please explain why.
tests/intensive/cvat.py; quick manual smoketest
Release Notes
CVAT integration: support CVAT server v2.4
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
What areas of FiftyOne does this PR affect?
fiftyonePython library changes