Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax starlette dependency #2925

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Relax starlette dependency #2925

merged 1 commit into from
Apr 25, 2023

Conversation

benjaminpkane
Copy link
Contributor

@benjaminpkane benjaminpkane commented Apr 25, 2023

Relaxes the starlette dependency per a user request. All minor versions were verified to work

@benjaminpkane benjaminpkane requested a review from a team April 25, 2023 16:35
@benjaminpkane benjaminpkane self-assigned this Apr 25, 2023
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (a13d909) 62.03% compared to head (fde3823) 62.06%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2925      +/-   ##
===========================================
+ Coverage    62.03%   62.06%   +0.02%     
===========================================
  Files          259      259              
  Lines        43949    43981      +32     
  Branches       350      350              
===========================================
+ Hits         27263    27295      +32     
  Misses       16686    16686              
Flag Coverage Δ
app 48.61% <ø> (ø)
python 99.43% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@sashankaryal sashankaryal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benjaminpkane benjaminpkane merged commit 9f401b7 into develop Apr 25, 2023
@benjaminpkane benjaminpkane deleted the starlette branch April 25, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants