Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace pkg_resources with importlib.metadata #2930

Merged
merged 8 commits into from
May 11, 2023
Merged

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Apr 26, 2023

Replaces pkg_resources with importlib.metadata as per voxel51/eta#593.

@brimoor brimoor added the cleaning Code cleaning label Apr 26, 2023
@brimoor brimoor requested a review from a team April 26, 2023 14:07
@brimoor brimoor self-assigned this Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -13.66 ⚠️

Comparison is base (1fa069e) 62.18% compared to head (e20ff11) 48.52%.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2930       +/-   ##
============================================
- Coverage    62.18%   48.52%   -13.66%     
============================================
  Files          250      227       -23     
  Lines        45507    33265    -12242     
  Branches       319      319               
============================================
- Hits         28297    16143    -12154     
+ Misses       17210    17122       -88     
Flag Coverage Δ
app 48.52% <100.00%> (+<0.01%) ⬆️
python ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/packages/state/src/recoil/sidebar.ts 50.53% <100.00%> (+0.46%) ⬆️

... and 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brimoor brimoor changed the title Replace pkg_resources with importlib.metadata [HOLD] Replace pkg_resources with importlib.metadata May 10, 2023
@benjaminpkane
Copy link
Contributor

Tests are passing now with requirements/test.txt updated with the latest pytest

@brimoor brimoor changed the title [HOLD] Replace pkg_resources with importlib.metadata Replace pkg_resources with importlib.metadata May 11, 2023
@brimoor
Copy link
Contributor Author

brimoor commented May 11, 2023

Tests are passing now with requirements/test.txt updated with the latest pytest

Ah, thank you for finding the solution! 🙇

@brimoor brimoor merged commit 104d148 into develop May 11, 2023
@brimoor brimoor deleted the rm-pkg-resources branch May 11, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning Code cleaning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants