-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pkg_resources with importlib.metadata #2930
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2930 +/- ##
============================================
- Coverage 62.18% 48.52% -13.66%
============================================
Files 250 227 -23
Lines 45507 33265 -12242
Branches 319 319
============================================
- Hits 28297 16143 -12154
+ Misses 17210 17122 -88
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
239743b
to
4eb15b6
Compare
4eb15b6
to
5aadcf0
Compare
Tests are passing now with |
Ah, thank you for finding the solution! 🙇 |
Replaces
pkg_resources
withimportlib.metadata
as per voxel51/eta#593.