-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused loading text for tags #2948
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #2948 +/- ##
===========================================
- Coverage 62.19% 62.19% -0.01%
===========================================
Files 250 250
Lines 45526 45482 -44
Branches 319 319
===========================================
- Hits 28316 28288 -28
+ Misses 17210 17194 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benjaminpkane just tested this locally and I'm seeing samples
rather than XXX samples
above the grid. Count aggregation no longer running?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update: the grid count issue is not specific to this PR, so approving 👍
Co-authored-by: brimoor <[email protected]>
This update prevents the
tags
aggregation from being executed when it is not needed