Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused loading text for tags #2948

Merged
merged 3 commits into from
May 9, 2023
Merged

Remove unused loading text for tags #2948

merged 3 commits into from
May 9, 2023

Conversation

benjaminpkane
Copy link
Contributor

This update prevents the tags aggregation from being executed when it is not needed

@benjaminpkane benjaminpkane added bug Bug fixes app Issues related to App features labels May 3, 2023
@benjaminpkane benjaminpkane requested a review from brimoor May 3, 2023 00:03
@benjaminpkane benjaminpkane self-assigned this May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 95.23% and project coverage change: -0.01 ⚠️

Comparison is base (ecea758) 62.19% compared to head (1c2f668) 62.19%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2948      +/-   ##
===========================================
- Coverage    62.19%   62.19%   -0.01%     
===========================================
  Files          250      250              
  Lines        45526    45482      -44     
  Branches       319      319              
===========================================
- Hits         28316    28288      -28     
+ Misses       17210    17194      -16     
Flag Coverage Δ
app 48.52% <93.33%> (+<0.01%) ⬆️
python 99.41% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/packages/core/src/components/Actions/utils.tsx 40.57% <0.00%> (ø)
app/packages/state/src/recoil/sidebar.ts 50.53% <100.00%> (+0.46%) ⬆️
tests/unittests/view_tests.py 99.88% <100.00%> (-0.01%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benjaminpkane just tested this locally and I'm seeing samples rather than XXX samples above the grid. Count aggregation no longer running?

Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update: the grid count issue is not specific to this PR, so approving 👍

@benjaminpkane benjaminpkane merged commit 96edd9e into develop May 9, 2023
@benjaminpkane benjaminpkane deleted the no-tag-text branch May 9, 2023 18:53
lanzhenw pushed a commit that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Issues related to App features bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants