Addressing multiple PCD overlay feedback

app/packages/core/src/components/Actions/GroupMediaVisibilityContainer.tsx

@@ -1,7 +1,7 @@
 import { PillButton, PopoutSectionTitle } from "@fiftyone/components";
 import * as fos from "@fiftyone/state";
 import ViewComfyIcon from "@mui/icons-material/ViewComfy";
-import React, { useRef, useState } from "react";
+import { useRef, useState } from "react";
 import useMeasure from "react-use-measure";
 
 import {
@@ -20,7 +20,7 @@ interface GroupMediaVisibilityProps {
   modal: boolean;
 }
 
-const TITLE = "Toggle Media";
+const TITLE = "Toggle media";
 
 const Container = styled.div`
   position: relative;

app/packages/core/src/components/Actions/utils.tsx

@@ -192,7 +192,7 @@ export const tagParameters = ({
     ...params,
     label_fields: activeFields,
     target_labels: targetLabels,
-    slices: !groups ? [groupData?.slices] : null,
+    slices: !groups ? groupData?.slices : null,
     group_id: params.modal ? groupData?.id : null,
     sample_ids: getSampleIds(),
     labels:

app/packages/core/src/components/Modal/Modal.tsx

@@ -133,7 +133,7 @@ const SampleModal = () => {
                     onBlur={() => {
                       controller.set({ zIndex: "0" });
                     }}
-                    disabled={isOther || isLabelTag}
+                    disabled={isOther || isLabelTag || isTag}
                     key={key}
                     trigger={trigger}
                   />

app/packages/core/src/components/Sidebar/Entries/EntryCounts.tsx

@@ -57,7 +57,7 @@ export const PathEntryCounts = ({
   return shown.state === "loading" ? (
     <LoadingDots text="" />
   ) : (
-    typeof shown.contents === "number" && (
+    shown.contents && (
       <SuspenseEntryCounts
         countAtom={getAtom(false)}
         subcountAtom={getAtom(true)}

app/packages/looker-3d/src/action-bar/SliceSelector.tsx

@@ -18,15 +18,15 @@ export const SliceSelector = () => {
     }
 
     if (activePcdSlices.length === 1) {
-      return `${activePcdSlices[0]} selected`;
+      return `Showing ${activePcdSlices[0]}`;
     }
     if (activePcdSlices.length === 2) {
       return activePcdSlices.join(" and ");
     }
     if (activePcdSlices.length === allPcdSlices.length) {
-      return "All pcds selected";
+      return "Showing all point clouds";
     }
-    return `${activePcdSlices.length} point-clouds selected`;
+    return `Showing ${activePcdSlices.length} point clouds`;
   }, [activePcdSlices, allPcdSlices]);
 
   const handleActionClick = useCallback(() => {
@@ -43,7 +43,7 @@ export const SliceSelector = () => {
 
   return (
     <>
-      <ActionItem title="Select pcds">
+      <ActionItem title="Select point clouds">
         <div onClick={handleActionClick}>{activeSlicesLabel}</div>
       </ActionItem>
 
@@ -69,7 +69,7 @@ const PcdsSelector = () => {
 
   return (
     <ActionPopOver>
-      <PopoutSectionTitle>Select pcds</PopoutSectionTitle>
+      <PopoutSectionTitle>Select point clouds</PopoutSectionTitle>
       <div>
         {allPcdSlices.map((slice) => {
           return (