Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync map style to session storage #2965

Merged
merged 3 commits into from
May 8, 2023
Merged

Conversation

benjaminpkane
Copy link
Contributor

@benjaminpkane benjaminpkane commented May 5, 2023

Per user feedback, this PR adds map style as a browser storage persistent setting when its value is not a theme value (i.e. Dark and Light)

@benjaminpkane benjaminpkane self-assigned this May 5, 2023
@sashankaryal sashankaryal self-requested a review May 8, 2023 16:17
Copy link
Contributor

@sashankaryal sashankaryal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage: 42.85% and project coverage change: +13.35 🎉

Comparison is base (0330938) 48.90% compared to head (31cc923) 62.25%.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2965       +/-   ##
============================================
+ Coverage    48.90%   62.25%   +13.35%     
============================================
  Files          242      264       +22     
  Lines        33229    45169    +11940     
  Branches       356      356               
============================================
+ Hits         16249    28120    +11871     
- Misses       16980    17049       +69     
Flag Coverage Δ
app 48.89% <42.85%> (-0.01%) ⬇️
python 99.44% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/packages/state/src/recoil/atoms.ts 83.94% <42.85%> (-0.58%) ⬇️

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@benjaminpkane benjaminpkane merged commit 8d998cb into develop May 8, 2023
@benjaminpkane benjaminpkane deleted the map-style-browser-storage branch May 8, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants