Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug with search and space replacement #2975

Merged
merged 1 commit into from
May 8, 2023

Conversation

manivoxel51
Copy link
Contributor

What changes are proposed in this pull request?

noticed that all spaces should not be removed so we can support multi-word search ex: "description:bad annotations"
solution is to trim() instead

How is this patch tested? If it is not, please explain why.

(Details)

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Copy link
Contributor

@lanzhenw lanzhenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d335adb) 62.65% compared to head (d81747a) 62.65%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2975   +/-   ##
========================================
  Coverage    62.65%   62.65%           
========================================
  Files          270      270           
  Lines        46060    46060           
  Branches       362      362           
========================================
  Hits         28860    28860           
  Misses       17200    17200           
Flag Coverage Δ
app 49.78% <ø> (ø)
python 99.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@manivoxel51 manivoxel51 merged commit 64eca3a into develop May 8, 2023
@manivoxel51 manivoxel51 deleted the sunny/schema-search-improve branch May 8, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants