Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing imageview type #2989

Merged
merged 4 commits into from
May 9, 2023
Merged

fix missing imageview type #2989

merged 4 commits into from
May 9, 2023

Conversation

ritch
Copy link
Contributor

@ritch ritch commented May 9, 2023

  • adds / fixes the missing view type
  • need to support ListView(items=ImageView)

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: -0.01 ⚠️

Comparison is base (ecea758) 62.19% compared to head (a0bcbfe) 62.19%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2989      +/-   ##
===========================================
- Coverage    62.19%   62.19%   -0.01%     
===========================================
  Files          250      250              
  Lines        45526    45482      -44     
  Branches       319      319              
===========================================
- Hits         28316    28288      -28     
+ Misses       17210    17194      -16     
Flag Coverage Δ
app 48.52% <0.00%> (+<0.01%) ⬆️
python 99.41% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/packages/core/src/components/Actions/utils.tsx 40.57% <0.00%> (ø)
tests/unittests/view_tests.py 99.88% <100.00%> (-0.01%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ritch ritch merged commit 61245c8 into develop May 9, 2023
@ritch ritch deleted the fix-image-type branch May 9, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants