Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add component property to view #2992

Merged
merged 1 commit into from
May 10, 2023
Merged

add component property to view #2992

merged 1 commit into from
May 10, 2023

Conversation

imanjra
Copy link
Contributor

@imanjra imanjra commented May 9, 2023

What changes are proposed in this pull request?

Adds a kwarg to specificy custom component to render for an operator input or output

How is this patch tested? If it is not, please explain why.

(Details)

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@imanjra imanjra requested a review from ritch May 9, 2023 22:15
@imanjra imanjra force-pushed the operators-custom-component branch from eb501d6 to 1134fdb Compare May 9, 2023 22:16
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage: 97.43% and no project coverage change.

Comparison is base (ecea758) 62.19% compared to head (1134fdb) 62.20%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2992   +/-   ##
========================================
  Coverage    62.19%   62.20%           
========================================
  Files          250      250           
  Lines        45526    45488   -38     
  Branches       319      319           
========================================
- Hits         28316    28294   -22     
+ Misses       17210    17194   -16     
Flag Coverage Δ
app 48.52% <93.33%> (+<0.01%) ⬆️
python 99.41% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/packages/core/src/components/Actions/utils.tsx 40.57% <0.00%> (ø)
app/packages/state/src/recoil/sidebar.ts 50.53% <100.00%> (+0.46%) ⬆️
tests/unittests/dataset_tests.py 99.84% <100.00%> (+<0.01%) ⬆️
tests/unittests/view_tests.py 99.88% <100.00%> (-0.01%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ritch ritch merged commit 97c5685 into develop May 10, 2023
@ritch ritch deleted the operators-custom-component branch May 10, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants