Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address dynamic groups PR comments #3000

Merged
merged 3 commits into from
May 10, 2023
Merged

Conversation

sashankaryal
Copy link
Contributor

What changes are proposed in this pull request?

Address comments from #2934

How is this patch tested? If it is not, please explain why.

Locally

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@sashankaryal sashankaryal self-assigned this May 10, 2023
@sashankaryal sashankaryal requested review from a team and removed request for benjaminpkane May 10, 2023 22:11
@@ -105,7 +105,7 @@ export const GroupView: React.FC<GroupViewProps> = ({ subBar }) => {

{!shouldSplitVertically && is3DVisible && <GroupSample3d />}
</div>
{subBar ?? subBar}
{subBar && subBar}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider:

({ subBar = null })
// ...
{subBar}

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 58.33% and no project coverage change.

Comparison is base (2a0b837) 62.21% compared to head (9029a40) 62.21%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3000   +/-   ##
========================================
  Coverage    62.21%   62.21%           
========================================
  Files          250      250           
  Lines        45536    45543    +7     
  Branches       319      319           
========================================
+ Hits         28328    28335    +7     
  Misses       17208    17208           
Flag Coverage Δ
app 48.57% <58.33%> (+0.01%) ⬆️
python 99.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/packages/state/src/recoil/groups.ts 48.59% <58.33%> (+0.85%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sashankaryal sashankaryal merged commit b999034 into develop May 10, 2023
@sashankaryal sashankaryal deleted the refactor/dynamic-groups-app branch May 10, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants