Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sample url transformation edge case #3011

Merged
merged 1 commit into from
May 11, 2023
Merged

fix sample url transformation edge case #3011

merged 1 commit into from
May 11, 2023

Conversation

sashankaryal
Copy link
Contributor

What changes are proposed in this pull request?

Fixes edge case where array urls weren't being transformed into objects.

How is this patch tested? If it is not, please explain why.

Locally.

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@sashankaryal sashankaryal self-assigned this May 11, 2023
@sashankaryal sashankaryal requested a review from a team May 11, 2023 21:21
benjaminpkane
benjaminpkane approved these changes May 11, 2023
View reviewed changes
Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. LGTM

@sashankaryal sashankaryal merged commit 32c78b4 into release/v0.21.0 May 11, 2023
@sashankaryal sashankaryal deleted the bug/urls branch May 11, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminpkane benjaminpkane benjaminpkane approved these changes

Assignees

@sashankaryal sashankaryal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sashankaryal @benjaminpkane