-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
groups / dynamic groups bug fixes, fix e2e #3172
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #3172 +/- ##
===========================================
- Coverage 49.22% 49.18% -0.05%
===========================================
Files 230 230
Lines 34446 34478 +32
Branches 325 325
===========================================
Hits 16957 16957
- Misses 17489 17521 +32
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
ab987ba
to
5fd0ac3
Compare
cbc58ca
to
4eec477
Compare
context("unordered", () => { | ||
it("should create dynamic groups based on scene_id", () => { | ||
cy.get("[data-cy=entry-counts").should("have.text", "200 groups"); | ||
["left", "right", "pcd"].forEach((slice) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 cool
What changes are proposed in this pull request?
How is this patch tested? If it is not, please explain why.
Release Notes
Is this a user-facing change that should be mentioned in the release notes?
notes for FiftyOne users.
(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)
What areas of FiftyOne does this PR affect?
fiftyone
Python library changes