Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CVAT support for frame_start, frame_stop, and frame_step #3181

Merged
merged 10 commits into from
Jun 12, 2023

Conversation

ehofesmann
Copy link
Member

@ehofesmann ehofesmann commented Jun 10, 2023

CVAT has three arguments that let you define which portions of videos are uploaded: frame_start, frame_stop, and frame_step. This PR adds support to these through keyword arguments when calling dataset.annotate() with the CVAT backend as well as docs and tests.

image

@ehofesmann ehofesmann added feature Work on a feature request annotation Issues related to FiftyOne's annotation API labels Jun 10, 2023
@ehofesmann ehofesmann requested a review from a team June 10, 2023 17:29
@ehofesmann ehofesmann self-assigned this Jun 10, 2023
@ehofesmann ehofesmann changed the title Add CVAT support for frame_start frame_stop and frame_step Add CVAT support for frame_start, frame_stop, and frame_step Jun 10, 2023
@codecov
Copy link

codecov bot commented Jun 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: +34.06 🎉

Comparison is base (84d01e7) 15.12% compared to head (7c9a68e) 49.18%.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           release/v0.21.1    #3181       +/-   ##
====================================================
+ Coverage            15.12%   49.18%   +34.06%     
====================================================
  Files                  560      230      -330     
  Lines                68959    34478    -34481     
  Branches               597      325      -272     
====================================================
+ Hits                 10428    16957     +6529     
+ Misses               58531    17521    -41010     
Flag Coverage Δ
app 49.18% <ø> (+34.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 478 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@brimoor
Copy link
Contributor

brimoor commented Jun 10, 2023

@ehofesmann is there a reason you're casting from BaseDict and BaseList to dict and list?

@brimoor
Copy link
Contributor

brimoor commented Jun 12, 2023

@ehofesmann is there a reason you're casting from BaseDict and BaseList to dict and list?

oh I see you just need to use issubclass(d, dict) rather than type(d) == dict. I'll update.

Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ehofesmann ehofesmann merged commit a767903 into release/v0.21.1 Jun 12, 2023
@ehofesmann ehofesmann deleted the feature/cvat-frame-args branch June 12, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
annotation Issues related to FiftyOne's annotation API feature Work on a feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants