Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not recognize list fields as containing labels #3196

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Jun 12, 2023

No description provided.

@brimoor brimoor added the bug Bug fixes label Jun 12, 2023
@brimoor brimoor requested review from benjaminpkane and a team June 12, 2023 19:30
@brimoor brimoor self-assigned this Jun 12, 2023
@brimoor brimoor changed the base branch from develop to release/v0.21.1 June 12, 2023 19:31
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage: 13.61% and project coverage change: -34.05 ⚠️

Comparison is base (1076810) 49.18% compared to head (645b39e) 15.13%.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           release/v0.21.1    #3196       +/-   ##
====================================================
- Coverage            49.18%   15.13%   -34.05%     
====================================================
  Files                  230      562      +332     
  Lines                34478    69022    +34544     
  Branches               325      599      +274     
====================================================
- Hits                 16957    10448     -6509     
- Misses               17521    58574    +41053     
Flag Coverage Δ
app 15.13% <13.61%> (-34.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/packages/app/src/Network.tsx 0.00% <0.00%> (ø)
app/packages/app/src/index.tsx 0.00% <0.00%> (ø)
app/packages/core/src/Dataset.ts 0.00% <0.00%> (ø)
app/packages/core/src/Root/Datasets/Dataset.tsx 0.00% <0.00%> (ø)
app/packages/core/src/Root/Root.tsx 0.00% <0.00%> (ø)
...pp/packages/core/src/components/Actions/Tagger.tsx 0.00% <0.00%> (ø)
...kages/core/src/components/Actions/similar/utils.ts 0.00% <0.00%> (ø)
...ages/core/src/components/ColorModal/ColorModal.tsx 0.00% <0.00%> (ø)
...s/core/src/components/ColorModal/ShareStyledDiv.ts 0.00% <0.00%> (ø)
app/packages/core/src/components/Dataset.tsx 0.00% <0.00%> (ø)
... and 40 more

... and 437 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjaminpkane benjaminpkane merged commit d8e8fe5 into release/v0.21.1 Jun 12, 2023
@benjaminpkane benjaminpkane deleted the bugfix/label-lists branch June 12, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants