Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix readonly mode for operator io #3225

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

imanjra
Copy link
Contributor

@imanjra imanjra commented Jun 26, 2023

What changes are proposed in this pull request?

Fixes readonly mode in operator io not working for all views

How is this patch tested? If it is not, please explain why.

(Details)

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 17.84% and project coverage change: +0.02 🎉

Comparison is base (30dbdf4) 15.13% compared to head (0259ef9) 15.15%.

❗ Current head 0259ef9 differs from pull request most recent head 003ae7c. Consider uploading reports for the commit 003ae7c to get more accurate results

Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/v0.21.1    #3225      +/-   ##
===================================================
+ Coverage            15.13%   15.15%   +0.02%     
===================================================
  Files                  562      563       +1     
  Lines                69022    68971      -51     
  Branches               599      600       +1     
===================================================
+ Hits                 10448    10455       +7     
+ Misses               58574    58516      -58     
Flag Coverage Δ
app 15.15% <17.84%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/.eslintrc.js 0.00% <0.00%> (ø)
app/packages/core/src/Root/Root.tsx 0.00% <0.00%> (ø)
.../packages/core/src/components/Actions/Selected.tsx 0.00% <0.00%> (ø)
app/packages/core/src/components/Grid/Grid.tsx 0.00% <0.00%> (ø)
.../DynamicGroup/NestedGroup/GroupElementsLinkBar.tsx 0.00% <0.00%> (ø)
...oup/NestedGroup/PaginationComponentWithTooltip.tsx 0.00% <0.00%> (ø)
...nts/Modal/Group/DynamicGroup/NestedGroup/index.tsx 0.00% <0.00%> (ø)
...Modal/Group/DynamicGroup/UnorderedDynamicGroup.tsx 0.00% <0.00%> (ø)
...cGroup/carousel/DynamicGroupsFlashlightWrapper.tsx 0.00% <0.00%> (ø)
...DynamicGroup/carousel/useSetDynamicGroupSample.tsx 0.00% <0.00%> (ø)
... and 47 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@imanjra imanjra marked this pull request as ready for review June 26, 2023 18:19
@imanjra imanjra requested a review from a team June 26, 2023 18:19
Copy link
Contributor

@brimoor brimoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and confirmed that this works, thanks! 🥇

@imanjra imanjra merged commit 807c634 into release/v0.21.1 Jun 26, 2023
12 of 13 checks passed
@imanjra imanjra deleted the operators-fix-readonly branch June 26, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants