Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numeric fields display bug #3240

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Conversation

lanzhenw
Copy link
Contributor

Fix a display bug for numeric field
Previously after I assign one value to float field, the value is shown as none.
Screenshot 2023-06-29 at 4 06 10 PM

Fix:
Screenshot 2023-06-29 at 10 28 59 PM
Screenshot 2023-06-29 at 10 22 05 PM

What changes are proposed in this pull request?

(Please fill in changes proposed in this fix)

How is this patch tested? If it is not, please explain why.

(Details)

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

@lanzhenw lanzhenw self-assigned this Jun 30, 2023
@lanzhenw lanzhenw added the bug Bug fixes label Jun 30, 2023
Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@benjaminpkane benjaminpkane merged commit da1b464 into release/v0.21.1 Jun 30, 2023
@benjaminpkane benjaminpkane deleted the fix-numeric-fields branch June 30, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants