Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multi PCD groups in the modal #4044

Merged
merged 5 commits into from
Feb 6, 2024
Merged

Fix multi PCD groups in the modal #4044

merged 5 commits into from
Feb 6, 2024

Conversation

benjaminpkane
Copy link
Contributor

Fixes non-default pcd slice rendering in the modal

import fiftyone.zoo as foz

dataset = foz.load_zoo_dataset("quickstart-groups", max_samples=3)
dataset.persistent = True
dataset.group_slice = "pcd"
extra = dataset.first().copy()
extra.group.name = "extra"
dataset.add_sample(extra)

Before

Screen.Recording.2024-01-25.at.4.38.51.PM.mov

After

Screen.Recording.2024-01-25.at.4.38.02.PM.mov

@benjaminpkane benjaminpkane added bug Bug fixes app Issues related to App features labels Jan 25, 2024
@benjaminpkane benjaminpkane requested a review from a team January 25, 2024 22:40
@benjaminpkane benjaminpkane self-assigned this Jan 25, 2024
@benjaminpkane benjaminpkane changed the title Multi pcd Fix multi PCD groups in the modal Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (328eb76) 15.98% compared to head (463a3f8) 15.98%.

Files Patch % Lines
...ackages/looker-3d/src/action-bar/SliceSelector.tsx 0.00% 5 Missing ⚠️
.../src/components/Sidebar/Entries/PathValueEntry.tsx 0.00% 3 Missing ⚠️
app/packages/state/src/recoil/groups.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/v0.23.5    #4044      +/-   ##
===================================================
- Coverage            15.98%   15.98%   -0.01%     
===================================================
  Files                  732      732              
  Lines                81966    81971       +5     
  Branches              1101     1101              
===================================================
  Hits                 13100    13100              
- Misses               68866    68871       +5     
Flag Coverage Δ
app 15.98% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from release/v0.23.4 to main January 25, 2024 23:27
@benjaminpkane benjaminpkane changed the base branch from main to release/v0.23.5 January 26, 2024 14:43
@benjaminpkane benjaminpkane marked this pull request as ready for review January 26, 2024 14:44
Copy link
Contributor

@sashankaryal sashankaryal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 for adding tests too

@benjaminpkane benjaminpkane merged commit da2a372 into release/v0.23.5 Feb 6, 2024
12 of 13 checks passed
@benjaminpkane benjaminpkane deleted the multi-pcd branch February 6, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Issues related to App features bug Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants