-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynamic groups bug fixes #4068
dynamic groups bug fixes #4068
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v0.23.5 #4068 +/- ##
==================================================
Coverage ? 15.99%
==================================================
Files ? 732
Lines ? 82033
Branches ? 1110
==================================================
Hits ? 13123
Misses ? 68910
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
8279afa
to
b84c043
Compare
e2e ran to completion 🆒 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. LGTM! I like the aggregation calls change 🚀
This PR contains a number of dynamic groups bug fixes and improvements.
sidebarSampleId
was causing a lot of stray aggregations query to fire, and it has been converted into something simpler. This makes imavid looker feel much more smooth.Testing
All groups e2e tests are green locally.