Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic groups bug fixes #4068

Merged
merged 9 commits into from
Feb 7, 2024
Merged

Conversation

sashankaryal
Copy link
Contributor

@sashankaryal sashankaryal commented Feb 6, 2024

This PR contains a number of dynamic groups bug fixes and improvements.

  1. Only render dynamic groups configuration options when relevant
  2. The "suspend" logic previously implemented in sidebarSampleId was causing a lot of stray aggregations query to fire, and it has been converted into something simpler. This makes imavid looker feel much more smooth.
  3. Reset dynamic groups view mode to pagination after coming back from video mode.
  4. Fix e2e.

Testing

All groups e2e tests are green locally.

@sashankaryal sashankaryal changed the base branch from develop to release/v0.23.5 February 6, 2024 21:57
Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/v0.23.5@bd817b8). Click here to learn what that means.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/v0.23.5    #4068   +/-   ##
==================================================
  Coverage                   ?   15.99%           
==================================================
  Files                      ?      732           
  Lines                      ?    82033           
  Branches                   ?     1110           
==================================================
  Hits                       ?    13123           
  Misses                     ?    68910           
  Partials                   ?        0           
Flag Coverage Δ
app 15.99% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sashankaryal sashankaryal self-assigned this Feb 6, 2024
@sashankaryal sashankaryal marked this pull request as ready for review February 6, 2024 22:36
@sashankaryal sashankaryal changed the title [wip] dynamic groups bug fixes dynamic groups bug fixes Feb 6, 2024
@benjaminpkane
Copy link
Contributor

e2e ran to completion 🆒 🤔

benjaminpkane
benjaminpkane previously approved these changes Feb 7, 2024
Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM! I like the aggregation calls change 🚀

@sashankaryal sashankaryal merged commit 9010d08 into release/v0.23.5 Feb 7, 2024
12 of 13 checks passed
@sashankaryal sashankaryal deleted the bugfix/dynamic-groups branch February 7, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants