-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
saved views bug fix + e2e fixes #4072
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/v0.23.5 #4072 +/- ##
==================================================
Coverage ? 15.99%
==================================================
Files ? 732
Lines ? 82062
Branches ? 1110
==================================================
Hits ? 13123
Misses ? 68939
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Currently having difficulty with my local playwright environment. It'd be a shame to disable all these tests. I personally haven't been able to reproduce the call stack issue |
Happy to defer to @manivoxel51. But maybe we just disable/fix the |
@sashankaryal I'll pull and test around tomorrow. haven't had a chance to dive deep. thanks for raising this 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm too! 🍨
pulled and tested around
disablePortal
prop. On e2e side, because of this change, MUI backdrop intercepts mouse clicks and keypresses, and tests fail. The broken tests in saved views spec have been annotated with.fixme()
until we we have a fix.