Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

saved views bug fix + e2e fixes #4072

Merged
merged 6 commits into from
Feb 11, 2024
Merged

Conversation

sashankaryal
Copy link
Contributor

@sashankaryal sashankaryal commented Feb 7, 2024

  • Fixed a bug in saved views editor caused by Max call stack - Modal._this.enforceFocus mui/material-ui#10341.
  • The editor doesn't work without disablePortal prop. On e2e side, because of this change, MUI backdrop intercepts mouse clicks and keypresses, and tests fail. The broken tests in saved views spec have been annotated with .fixme() until we we have a fix.
  • Update e2e dependencies, run linter, fix type issues, etc.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/v0.23.5@9010d08). Click here to learn what that means.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/v0.23.5    #4072   +/-   ##
==================================================
  Coverage                   ?   15.99%           
==================================================
  Files                      ?      732           
  Lines                      ?    82062           
  Branches                   ?     1110           
==================================================
  Hits                       ?    13123           
  Misses                     ?    68939           
  Partials                   ?        0           
Flag Coverage Δ
app 15.99% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminpkane
Copy link
Contributor

Currently having difficulty with my local playwright environment. It'd be a shame to disable all these tests. I personally haven't been able to reproduce the call stack issue

@benjaminpkane
Copy link
Contributor

Happy to defer to @manivoxel51. But maybe we just disable/fix the [saved views › searching through saved views works] spec?

@manivoxel51
Copy link
Contributor

@sashankaryal I'll pull and test around tomorrow. haven't had a chance to dive deep. thanks for raising this 🙌

Copy link
Contributor

@manivoxel51 manivoxel51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm too! 🍨

pulled and tested around

@sashankaryal sashankaryal merged commit 514abf9 into release/v0.23.5 Feb 11, 2024
13 checks passed
@sashankaryal sashankaryal deleted the bugfix/saved-views branch February 11, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants