fix tests after Beaker::Platform refactoring #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeni
force-pushed
the
test-platform
branch
from
0145c02
to
c45ca9e
Compare
evgeni
force-pushed
the
test-platform
branch
from
c45ca9e
to
7478426
Compare
|
Since this is a fix for voxpupuli/beaker@9d85e89, which was first released in 6.4.0, should we bump the minimal version in the gemspec to 6.4.0? |
No.
|
|
I also don't think this should be labeled |
evgeni
commented
Sep 20, 2024
|
|
||
| expect(dockerfile).to match(/pacman --sync --refresh --noconfirm archlinux-keyring/) | ||
| expect(dockerfile).to match(/pacman --sync --refresh --noconfirm --sysupgrade/) | ||
| expect(dockerfile).to match(/pacman --sync --noconfirm curl ntp net-tools openssh/) | ||
| expect(dockerfile).to match(/pacman --sync --noconfirm curl net-tools openssh/) |
There was a problem hiding this comment.
we could make this
Suggested change
| expect(dockerfile).to match(/pacman --sync --noconfirm curl net-tools openssh/) | |
| expect(dockerfile).to match(/pacman --sync --noconfirm curl/) |
and then it'd pass on 6.3 AND 6.4
bastelfreak
approved these changes
Sep 20, 2024
ekohl
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.