Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHG Doesn't allow numbers in the roles #149

Open
glennsarti opened this issue Feb 21, 2019 · 0 comments
Open

BHG Doesn't allow numbers in the roles #149

glennsarti opened this issue Feb 21, 2019 · 0 comments

Comments

@glennsarti
Copy link
Contributor

This works
Roles - abc,def,default

C:\Source\puppetlabs-powershell\powershell [MODULES-8358-add-pwsh-manager ≡]> bundle exec beaker-hostgenerator ubuntu1604-64abc,def,default.a
---
HOSTS:
  ubuntu1604-64-1:
    pe_dir:
    pe_ver:
    pe_upgrade_dir:
    pe_upgrade_ver:
    platform: ubuntu-16.04-amd64
    packaging_platform: ubuntu-16.04-amd64
    template: ubuntu-1604-x86_64
    hypervisor: vmpooler
    roles:
    - agent
    - abc
    - def
    - default
CONFIG:
  nfs_server: none
  consoleport: 443
  pooling_api: http://vmpooler.delivery.puppetlabs.net/

This doesn't work
Roles - abc,def6,default

C:\Source\puppetlabs-powershell\powershell [MODULES-8358-add-pwsh-manager ≡]> bundle exec beaker-hostgenerator ubuntu1604-64abc,def6,default.a
C:/Source/puppetlabs-powershell/powershell/.bundle/windows/ruby/2.4.0/gems/beaker-hostgenerator-1.1.26/lib/beaker-hostgenerator/parser.rb:174:in `parse_node_info_token': Invalid node_info token: 64abc,def6,default.a (BeakerHostGenerator::Exceptions::InvalidNodeSpecError)
        from C:/Source/puppetlabs-powershell/powershell/.bundle/windows/ruby/2.4.0/gems/beaker-hostgenerator-1.1.26/lib/beaker-hostgenerator/generator.rb:39:in `block in generate'
        from C:/Source/puppetlabs-powershell/powershell/.bundle/windows/ruby/2.4.0/gems/beaker-hostgenerator-1.1.26/lib/beaker-hostgenerator/generator.rb:30:in `each'
        from C:/Source/puppetlabs-powershell/powershell/.bundle/windows/ruby/2.4.0/gems/beaker-hostgenerator-1.1.26/lib/beaker-hostgenerator/generator.rb:30:in `generate'
        from C:/Source/puppetlabs-powershell/powershell/.bundle/windows/ruby/2.4.0/gems/beaker-hostgenerator-1.1.26/lib/beaker-hostgenerator/cli.rb:170:in `execute'
        from C:/Source/puppetlabs-powershell/powershell/.bundle/windows/ruby/2.4.0/gems/beaker-hostgenerator-1.1.26/lib/beaker-hostgenerator/cli.rb:176:in `execute!'
        from C:/Source/puppetlabs-powershell/powershell/.bundle/windows/ruby/2.4.0/gems/beaker-hostgenerator-1.1.26/bin/beaker-hostgenerator:10:in `<top (required)>'
        from C:/Source/puppetlabs-powershell/powershell/.bundle/windows/ruby/2.4.0/bin/beaker-hostgenerator:23:in `load'
        from C:/Source/puppetlabs-powershell/powershell/.bundle/windows/ruby/2.4.0/bin/beaker-hostgenerator:23:in `<main>'
C:\Source\puppetlabs-powershell\powershell [MODULES-8358-add-pwsh-manager ≡]>
glennsarti added a commit to glennsarti/puppetlabs-powershell that referenced this issue Feb 21, 2019
…ersion

Previously the acceptance tests were gated on the `powershell6` role within the
beaker hosts file.  However Beaker Host Generator doesn't understand numbers in
the role name [1].  This commit changes the PowerShell core detection to use
the key/value property `powershell` for each host.  This has the added benefit
to be able to specify the version of powershell core to be tested, not just
latest.

[1] voxpupuli/beaker-hostgenerator#149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant