-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby 3.2 support #120
Add Ruby 3.2 support #120
Conversation
also contains #119 |
needs some work in beaker-docker first |
It is a legitimate failure due to Ruby 3.2 changes. |
voxpupuli/beaker-docker#93 should address that. |
after this is merged, I would also like to update the CI matrix to make the new job the new required one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay. My only concern is that as far as I tested it on FreeBSD, Puppet 6/7 does not work with Ruby 3.2 because fast_gettext
is currently broken due to the usage of untaint
deprecated in ruby 2.7 (could not fix it correctly yet, so no PR at the moment).
Maybe defaulting to Ruby 3.2 will have some side effects with this for some of our gems and we will have to use 3.1 for them until this is fixed.
If we want consistency across all gems, I would rather suggest using 3.1 as the default version.
Edit: This was fixed a while ago. The FreeBSD dependency just need a refresh
No description provided.