remove question mark from regex in encrypted? method #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed on this PR https://github.com/voxpupuli/puppet-syntax/pull/127/files The question mark is irrelevant in this REGEX, so with the IAC team, we decided to fix it from the upstream project.
ekohl
approved these changes
Feb 15, 2021
bastelfreak
approved these changes
Feb 15, 2021
kenyon
approved these changes
Feb 15, 2021
kenyon
changed the title
kenyon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
As discussed on this PR https://github.com/voxpupuli/puppet-syntax/pull/127/files
The question mark is irrelevant in this REGEX, so with the IAC team, we decided to fix it from the upstream project.
Thanks!