Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only rescue errors explicitly #239

Merged
merged 2 commits into from
Dec 23, 2015

Commits on Mar 6, 2015

  1. Only rescue errors explicitly

    There are a lot of places in the code where we rescue any error, at all.
    That's quite dangerous, as it could conceal bugs.
    
    I've changed it so that we always specify which error class we want to
    catch. Mostly it's been a minor change, but there are two API changes:
    
    * When it comes to loading data I've had to introduce an explicit list
      of protocols which we can load json over (otherwise it's possible to
      have a uri with a scheme that makes no sense - it'd still be a valid
      uri but loading from it is impossible). I've used the list of
      protocols that addressable recognizes for now.
    * No matter what JSON parser you use, we now always raise a
      JSON::Schema::JsonParseError. Without doing this it would be tricky to
      handle parser errors identically, for all parsers (the other option
      would be to catch a long list of potential parse errors, but this
      seems more sensible).
    iainbeeston committed Mar 6, 2015
    Configuration menu
    Copy the full SHA
    cb52269 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2015

  1. Added a changelog

    Iain Beeston committed Dec 23, 2015
    Configuration menu
    Copy the full SHA
    31a620b View commit details
    Browse the repository at this point in the history