-
-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up JSON::Validator.validate #255
Closed
Closed
Commits on May 14, 2015
-
Speed up JSON::Validator.validate
Addressible's URI parsing shows up at the top of the profiler for our use case. This patch adds a cache to JSON::Util::URI.normalized_uri, to trade CPU time for memory. There are other expensive Addressible methods that should be cached elsewhere. benchmark: https://github.com/mjc/json-schema-perf MRI 2.2.2 before: 825.363 (± 6.2%) i/s MRI 2.2.2 after: 1.436k (± 4.5%) i/s 1.74x faster JRuby 1.7.20 before: 1.445k (± 2.5%) i/s JRuby 1.7.20 after: 2.272k (± 6.1%) i/s 1.57x faster
Configuration menu - View commit details
-
Copy full SHA for 078f745 - Browse repository at this point
Copy the full SHA 078f745View commit details
Commits on May 18, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 6c26bf5 - Browse repository at this point
Copy the full SHA 6c26bf5View commit details
Commits on May 19, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 6687747 - Browse repository at this point
Copy the full SHA 6687747View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0807525 - Browse repository at this point
Copy the full SHA 0807525View commit details
Commits on May 20, 2015
-
Don't update url fragment if it's already blank or nil
Addressable::URI#fragment= triggers a revalidation of the URL, which is super slow. Don't do this when it isn't necessary.
Configuration menu - View commit details
-
Copy full SHA for c108723 - Browse repository at this point
Copy the full SHA c108723View commit details -
Configuration menu - View commit details
-
Copy full SHA for ac24f48 - Browse repository at this point
Copy the full SHA ac24f48View commit details
Commits on May 21, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 4365f88 - Browse repository at this point
Copy the full SHA 4365f88View commit details -
Configuration menu - View commit details
-
Copy full SHA for b25cd15 - Browse repository at this point
Copy the full SHA b25cd15View commit details
Commits on Jun 4, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 8d996e1 - Browse repository at this point
Copy the full SHA 8d996e1View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.