Avoid Dir.chdir by passing cwd to execute() and simplify %s detection in custom_command #531
+10
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the cheaper include? to determine if %s is in custom_command. It also simplifies the expression with a safe operator.
The use of chdir is problematic in threaded environments (only one thread may chdir) and Puppet has a native method for this. Link: puppetlabs/puppet#9387
kenyon
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of chdir is problematic in threaded environments (only one thread may chdir) and Puppet has a native method for this. See puppetlabs/puppet#9387 for more information.
It also simplifies the detection of
%sincustom_commandby using the cheaper include? method. The safe operator makes it even shorter.