Drop support for Puppet 4, 5, 6 (EOL) #101
Conversation
These corrections are always safe: bundle exec rubocop -a
These ones are sometimes not safe bundle exec rubocop -A
The list of supported Operating Systems is outdated. Update it and add some basic acceptance tests to ensure the code is valid.
While AIO Puppet has a well-known path to augeas lenses, non-AIO Puppet use a sysstem path that is OS-dependant. Rework the way this path is retrieved so that we can extand this easily using Hiera.
Puppet 7 and Puppet 8 are the currently supported versions of Puppet. Older versions have reached EOL and are not used in CI, so do not pretend the module work with them as it is now untested.
smortex
added
the
backwards-incompatible
|
Interesting, in facterdb, Archlinux (and a bunch of other OS) does not have a |
|
I'd rather the individual PRs aggregated here are merged separately so they appear in the change-log. |
|
@jhoblitt they'll all appear in the changelog when closed, regardless of how they are merged. |
There was a problem hiding this comment.
There is a lot going on this PR that I feel would be better merged as isolated PRs that appear in the changelog. Also, some of the commits in this branch have a lot going on in them that isn't reflected in the commit messages. E.g. f6974ed
The PR title here also won't be very helpful in the changelog. What versions of puppet is support being dropped for?
I suggest starting with a small PR that only removes the EOL puppet versions.
Closed but unmerged PRs do not appear in the changelog. |
When this PR is merged, the included ones will also be closed as merged. |
AFAICT, in that commit, all of the deleted code was only applicable to EOL versions of Puppet, where Augeas was not included in the all-in-one packages like we have now. |
smortex
changed the title
👍 Fixed, thanks!
That's correct, when all commits in a PR are merged, the PR is marked as merged and GitHub ChangeLog Generator include it as expected.
Correct, and we also discover that the legacy code was used on some platforms because they do not ship with |
|
Could we either accept the arch failure and merge this or remove arch from this PR? We need to get a forge release out. |
@bastelfreak you are my Arch referent :-D What do you think we should do? |
|
The Arch Linux failure was an actual bug. the puppet package didn't depend on ruby-augeas. I fixed the package upstream. |
Also include: