Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require a version when installing from GitHub #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Require a version when installing from GitHub #97

wants to merge 1 commit into from

Commits on Jul 18, 2023

  1. Require a version when installing from GitHub 

    The `caddy::version` parameter is only used when `caddy::install_method`
is "github", but no error was previously raised if the user set a
specific version that was ignored, and the resulting configuration was
not what the user expected.

In order to avoid confusion, do not default to an outdated version of
caddy when installing from GitHub (requiring the user to explicily tell
which version they want) and raise an error if a version is set but is
ignored.

This should make the module more user-friendly for new users.
    @smortex
    smortex committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    20d97f1 View commit details
    Browse the repository at this point in the history