Merge pull request #670 from EmpaticoOrg/zk

Add Zookeeper plugin

README.md

@@ -197,6 +197,8 @@ documentation for each plugin for configurable attributes.
 * `write_tsdb` (see [collectd::plugin::write_tsdb](#class-collectdpluginwrite_tsdb)
   below)
 * `zfs_arc` (see [collectd::plugin::zfs_arc](#class-collectdpluginzfs_arc) below)
+* `zookeeper` (see
+  [collectd::plugin::zookeeper](#class-collectdzookeeper) below)
 
 ### Class: `collectd::plugin::aggregation`
 
@@ -1833,6 +1835,15 @@ class { 'collectd::plugin::zfs_arc':
 }
 ```
 
+#### Class: `collectd::plugin::zookeeper`
+
+```puppet
+class { 'collectd::plugin::zookeeper':
+  zookeeper_host  => 'localhost',
+  zookeeper_port  => '2181',
+}
+```
+
 ##### types.db
 
 Collectd needs to know how to handle each collected datapoint.

manifests/plugin/zookeeper.pp

@@ -0,0 +1,15 @@
+class collectd::plugin::zookeeper (
+  Enum['present', 'absent'] $ensure           = 'present',
+  Optional[Integer]         $interval         = undef,
+  String                    $zookeeper_host   = 'localhost',
+  String                    $zookeeper_port   = '2181',
+) {
+
+  include ::collectd
+
+  collectd::plugin { 'zookeeper':
+    ensure   => $ensure,
+    content  => template('collectd/plugin/zookeeper.conf.erb'),
+    interval => $interval,
+  }
+}

spec/classes/collectd_plugin_zookeeper_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe 'collectd::plugin::zookeeper', type: :class do
+  let :facts do
+    {
+      osfamily: 'RedHat',
+      collectd_version: '5.5.0',
+      operatingsystemmajrelease: '7',
+      python_dir: '/usr/local/lib/python2.7/dist-packages'
+    }
+  end
+
+  context ':ensure => present and :zookeeper_host => \'myhost\'' do
+    let :params do
+      { zookeeper_host: 'myhost', zookeeper_port: '2181' }
+    end
+
+    it 'Will create /etc/collectd.d/10-zookeeper.conf' do
+      is_expected.to contain_file('write_riemann.load').with(ensure: 'present')
+      is_expected.to contain_file('write_riemann.load').with(path: '/etc/collectd.d/10-zookeeper.conf')
+      is_expected.to contain_file('write_riemann.load').with(content: %r{Host "myhost"})
+      is_expected.to contain_file('write_riemann.load').with(content: %r{Port "2181"})
+    end
+  end
+
+  context ':ensure => absent' do
+    let :params do
+      { zookeeper_host: ['myhost'], ensure: 'absent' }
+    end
+
+    it 'Will not create ' do
+      is_expected.to contain_file('zookeeper.load').with(ensure: 'absent',
+                                                         path: '/etc/collectd.d/10-zookeeper.conf')
+    end
+  end
+end

templates/plugin/zookeeper.conf.erb

@@ -0,0 +1,4 @@
+<Plugin "zookeeper">
+  Host "<%= @zookeeper_host %>"
+  Port "<%= @zookeeper_port %>"
+</Plugin>