Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collectd::plugin::python::module does not support number options #662

Closed
LionelCons opened this issue Apr 6, 2017 · 2 comments · Fixed by #818
Closed

collectd::plugin::python::module does not support number options #662

LionelCons opened this issue Apr 6, 2017 · 2 comments · Fixed by #818
Labels
bug Something isn't working

Comments

@LionelCons
Copy link

This module (via module.conf.erb) only supports boolean and string options.

When a number is given (e.g. config => [{ 'Port' => 1234}]), Puppet fails with "undefined method scan for 1234:Fixnum".

When a string is given (e.g. config => [{ 'Port' => '1234'}]), we end up with a string in python-config.conf.

Please add support for numbers: they should be rendered as they are, with no double quotes around.
@juniorsysadmin juniorsysadmin added the enhancement New feature or request label Dec 25, 2017
traylenator added a commit to traylenator/puppet-collectd that referenced this issue Jun 13, 2018
@traylenator
Fixes voxpupuli#662 accept numbers into configuration file
a8d6696 
With a configuration of

```puppet
collectd::python::python{'foo':
  modules => { 'foo' => { config => [{'value' => 4}]
                        }
             }
}
```

Puppet fails with `undefined method scan for 4:Fixnum`.

Integers and floats are now accepted and displayed as numbers.
@traylenator
Copy link
Contributor

@juniorsysadmin I think this is bug rather than an enhancement since it currently it always fails with a parse error.

@traylenator traylenator mentioned this issue Jun 13, 2018
Merged
bastelfreak added a commit that referenced this issue Jun 13, 2018
@bastelfreak
Merge pull request #818 from traylenator/int
3abffed 
Fixes #662 accept numbers into configuration file
@juniorsysadmin juniorsysadmin added bug Something isn't working and removed enhancement New feature or request labels Jun 13, 2018
@juniorsysadmin
Copy link
Member

@traylenator Label fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #662 accept numbers into configuration file traylenator/puppet-collectd
3 participants
@traylenator @LionelCons @juniorsysadmin