Stop specifying $name as the default host value #631
Conversation
This should not be the default, it doesn't make sense for localhost bound JMX connections.
| @@ -24,8 +24,8 @@ | |||
| puppetversion: Puppet.version, | |||
| facterversion: Facter.version | |||
| } | |||
| default_facts.merge!(YAML.load(File.read(File.expand_path('../default_facts.yml', __FILE__)))) if File.exist?(File.expand_path('../default_facts.yml', __FILE__)) | |||
| default_facts.merge!(YAML.load(File.read(File.expand_path('../default_module_facts.yml', __FILE__)))) if File.exist?(File.expand_path('../default_module_facts.yml', __FILE__)) | |||
| default_facts.merge!(YAML.safe_load(File.read(File.expand_path('../default_facts.yml', __FILE__)))) if File.exist?(File.expand_path('../default_facts.yml', __FILE__)) | |||
There was a problem hiding this comment.
@jamtur01 hrm, we just reverted the safe_load calls earlier today. I think this may need a modulesync in the morning, and this change dropped, before we merge this.
There was a problem hiding this comment.
I pulled master before I created this - that update wasn't in there - given the length of the time it takes the run the tests it's kinda annoying this isn't sync'ed. :(
|
The test failure here is unrelated to the branch. |
|
It is annoying, and I'm sorry for that! We are trying to do better with the modulesyncs. Thank you for your patience. This does look good to me and we can merge it once the other tests all pass, then I can do the modulesync in the morning to fix the build status. Thanks! |
|
And it completed while I was typing. Boom! |
|
@jamtur01 as an aside, if there is something we can do to speed up the tests, please open an issue and let us know! |
This should not be the default, it doesn't make sense for localhost
bound JMX connections.