Add SNMPv3 support #665
Merged
Add SNMPv3 support #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Re-running checks... |
|
Tried this out but was getting a lot of errors from the data types (using PE 2016.4.3 which includes Puppet 4.7). I've made my own fork with the changes (minus the Puppet4 data types) here which is passing tests for me. |
|
What were the errors? I don't think it's realistic to just remove all of the Puppet 4 types but it might be a simple fix. An example of how you're calling the module/define would be good too. |
|
Hi @bodgit , thanks for the PR. Can you please rebase it against latest master? |
* Refactor SNMP plugin to use Puppet 4 data types. * Rename `invertmatch` and `instanceprefix` parameters in `collectd::plugin::snmp::data` defined type to match the hash keys passed in the `data` parameter in `collectd::plugin::snmp` class.
bodgit
force-pushed
the
snmpv3
branch
2 times, most recently
from
b3deef3
to
d063661
Compare
|
Done. Tests all seem to pass. |
bastelfreak
reviewed
Jul 21, 2017
| $data = {}, | ||
| $hosts = {}, | ||
| $interval = undef, | ||
| Enum['present', 'absent'] $ensure = 'present', |
|
Thanks @bodgit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds SNMPv3 support to the SNMP plugin which should fix #236, I also took the opportunity to refactor the plugin to use Puppet 4.x data types.
The only breaking change AFAICT is that I renamed the
invertmatchandinstanceprefixparameters toinvert_matchandinstance_prefixrespectively in thecollectd::plugin::snmp::datadefined type to match the hash keys passed in thedataparameter incollectd::plugin::snmpclass given everything else matched up.To keep my employers legal team happy, I have to include the following: