Use service_name param instead of static collectd, #688 #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you look at the test failures? needs updating since the service_name doesn't default to 'collectd' for all supported OSes. |
|
Is this because the manifests now refer to "service { $service_name:" instead of "service { 'collectd':"? |
juniorsysadmin
added a commit
to juniorsysadmin/puppet-collectd
that referenced
this pull request
Mar 31, 2018
The $service_name variable exists but is useless as Service['collectd'] is used in most places. More or less identical to voxpupuli#738 by @fnoop Fixes voxpupuli#688
juniorsysadmin
added a commit
to juniorsysadmin/puppet-collectd
that referenced
this pull request
Mar 31, 2018
The $service_name variable exists but is useless as Service['collectd'] is used in most places. More or less identical to voxpupuli#738 by @fnoop Fixes voxpupuli#688
|
We implemented this in #771 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix behaviour reported in #688. puppet-collectd currently refers to the controlled service as
Service['collectd']. This means that if you specify $collectd::service_name, you still cannot control the actual 'collectd' service outside of puppet-collectd. This PR changes all references from 'collectd' to $collectd::service_name.