Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize file permissions, allow non-root #767

Merged

Conversation

juniorsysadmin
Copy link
Member

@juniorsysadmin juniorsysadmin commented Mar 30, 2018

This change allows .conf and .load file permission to be changed from a
single place, and potentially helps with non-root installations.

  • Change root_group parameter to config_group
  • Add config_owner and config_mode parameters
  • collectd::plugin::filter::chain Change default permissions for the
    conf file from 0644 to 0640
  • collectd::plugin::perl Replace missing root_user with config_owner
  • collectd::plugin::perl Change default permissions for the
    configuration directory from 0755 to 0750
  • collectd::plugin::perl::plugin Change default permissions for the
    conf file from 0644 to 0640
  • collectd::plugin::python Change default permissions for the
    Python module directories from 0755 to 0750
  • collectd::plugin::tail::file change default conf file permissions
    from 0644 to 0640
  • collectd::typesdb Add config_mode and config_owner parameters

Fixes #719

This change allows .conf and .load file permission to be changed from a
single place, and potentially helps with non-root installations.

- Change root_group parameter to config_group
- Add config_owner and config_mode parameters
- collectd::plugin::filter::chain Change default permissions for the
  conf file from 0644 to 0640
- collectd::plugin::perl Replace missing root_user with config_owner
- collectd::plugin::perl Change default permissions for the
  configuration directory from 0755 to 0750
- collectd::plugin::perl::plugin Change default permissions for the
  conf file from 0644 to 0640
- collectd::plugin::python Change default permissions for the
  Python module directories from 0755 to 0750
- collectd::plugin::tail::file change default conf file permissions
  from 0644 to 0640
- collectd::typesdb Add config_mode and config_owner parameters
@juniorsysadmin juniorsysadmin added backwards-incompatible bug Something isn't working enhancement New feature or request needs-docs needs-tests and removed bug Something isn't working enhancement New feature or request labels Mar 30, 2018
@juniorsysadmin
Copy link
Member Author

Doc and test updates to be done later in another PR

@juniorsysadmin juniorsysadmin added enhancement New feature or request and removed needs-docs needs-tests labels Mar 31, 2018
@bastelfreak
Copy link
Member

Should we really do the doc update in another PR? Do we need to adjust tests?

@juniorsysadmin
Copy link
Member Author

juniorsysadmin commented Mar 31, 2018

Should we really do the doc update in another PR? Do we need to adjust tests?

root_group is not documented at the moment, nor explicitly tested. I would prefer to do separate additions to all of our tests after further some major changes are done shortly, then a separate doc-update pass. Unless the changes look quite risky with high probability of breaking something...

@bastelfreak bastelfreak merged commit 22ba395 into voxpupuli:master Mar 31, 2018
@juniorsysadmin juniorsysadmin deleted the config-consistent-permissions branch March 31, 2018 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants