Add puppet tasks to call collectdctl #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a new dependency to metadata.yaml - I'm easily persuaded this should just be a comment in the README. |
traylenator
changed the title
Two puppet tasks
* collectd::listval - lists all collectd metrics on a node
* collectd::getval metric=load/load-relative - shows values
of a particular metric
For example
```bash
$ bolt -u root task run mine::getval metric=load/load-relative -n node.example.org
Started on node.example.org...
Finished on node.example.org:
{
"metric": "load/load-relative",
"values": {
"shortterm": "1.750000e-01",
"longterm": "8.000000e-02",
"midterm": "8.500000e-02"
}
}
```
|
There is a massive lack of tests here. Very happy to do some but we need some framework. |
I think it's fine in the metadata. |
|
It's broken on centos6 with python 2.6 . I have a fix migrating to |
Mostly to avoid python 2.6 on CentOS 6 use python3 explictly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Two puppet tasks
of a particular metric
For example
$ bolt -u root task run collectd::getval metric=load/load-relative -n node.example.org Started on node.example.org... Finished on node.example.org: { "metric": "load/load-relative", "values": { "shortterm": "1.750000e-01", "longterm": "8.000000e-02", "midterm": "8.500000e-02" } }