-
-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mce log plugin #904
Add Mce log plugin #904
Conversation
README.md
Outdated
@@ -132,6 +132,7 @@ documentation for each plugin for configurable attributes. | |||
* `hddtemp` (see [collectd::plugin::hddtemp](#class-collectdpluginhddtemp) below) | |||
* `hugepages` (see [collectd::plugin::hugepages](#class-collectdpluginhugepages) below) | |||
* `intel_pmu` (see [collectd::plugin::intel_pmu](#class-collectdpluginintel_pmu) below) | |||
* `mcelog` (see [collectd::plugin::mcelog](#class-collectdpluginmcelog) below) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please move this down to keep the list sorted alphabetical?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved it down.
templates/plugin/mcelog.conf.erb
Outdated
@@ -0,0 +1,10 @@ | |||
<Plugin mcelog> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please convert this to an epp template? We require this for new templates. For our other review guidelines please have a look at https://voxpupuli.org/docs/reviewing_pr/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Converted to epp template
let :facts do | ||
facts | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please also ensure that this compiles properly?
Something like this should work:
it { is_expected.to compile.with_all_deps }
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
Intel Mcelog plugin https://collectd.org/documentation/manpages/collectd.conf.5.shtml#plugin_mcelog