Fix more failing master tests #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 20, 2020 14:53
With the previous behaviour, _both_ providers were being considered, and the older `users` provider was winning. This meant we were using the deprecated `bin/x-pack/users` script.
Update signatures to SHA256, and move the certificate SANS config onto the node certs.
Dropping support from this module for ES 5 means that we only support 'current'' and 'previous' major versions, which is a saner approach.
fatmcgav
force-pushed
the
confine_elasticsearch-user_providers
branch
from
ccff445
to
090a31f
Compare
fatmcgav
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1074 and #1075 should have fixed the tests for
master.However I spotted that there are a subset of tests that only run on PR's from branches within the
elastic/puppet-elasticsearchrepo, so they weren't being executed on my forked PR's.Summary of changes:
elasticsearch_userproviders:With the previous behaviour, both providers were being considered, and
the older
usersprovider was winning. This meant we were using thedeprecated
bin/x-pack/usersscript.Use SHA256 signatures, tweak the CN's and move the SANS config onto the node cert generation.
This was necessary due to the changes required to get TLS and XPack tests to pass on
6.x.Therefore moving forward, this module will support the "current" major version and "previous" major version.
With the module moving towards supporting
7.x, the time is right to drop support for5.x.Any users that still need to support ES
5.xcan install and use the6.xversions of this module.