Support for teams, dashboard permissions and memberships #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 21, 2020 15:39
In order to be able to manage organizations properly, they should be able to be deleted as well as created. To make things predictable, the default organization cannot be modified.
|
Dear @DavidReubenWhite, thanks for the PR! This is Vox Pupuli Tasks, your friendly Vox Pupuli Github Bot. I noticed that your pull request has CI failures. Can you please have a look at the failing CI jobs? |
bastelfreak
approved these changes
May 2, 2020
|
LGTM Adding a few acceptance tests would ensure that this does not become brittle in the future. |
ghoneycutt
approved these changes
May 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the following concerns:
teams
Currently there is no support in this module for managing teams within an organization. Have added this type. Allows the home dashboard for team to be set / updated also.
organizations
To bring orgs in line with other resources - have updated this type so that orgs can be deleted. Couple of caveats to ensure predictability - default org "mainOrg." cannot be modified and if an organization is deleted, the orgnanization in use is returned to the default org.
dashboard permissions
I see another merge just now where the folder permissions were set on the folder itself. I am open to redoing the permissions as properties on a dashboard but I feel having permissions as a different type is easier to use and saves having to use hashes.
Able to set permissions on a dashboard for either a user or a team. Once permissions are set, the default permissions on a dashboard are removed. Otherwise this defeats the point of setting permissions per team/user.
memberships
This is the concept of a user belonging to an organization or a team.
autorequires
Due to the reliance on some of these types on other types being defined prior, these new types have autorequires to ensure ordering is done properly without the end user having to do it. As long as the resources specified in the parameters are present - it will work.