Allow grafana_team home dashboard to be scoped to a folder #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FWIW I just pushed this out to my Grafana test and production instances running Grafana 7.4.1 and it worked as expected. |
bastelfreak
approved these changes
Mar 16, 2021
|
@bastelfreak Any chance this can get merged if things look good? |
bastelfreak
approved these changes
Jun 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
In my environment we might have the dashboard
Node Metricsin numerous folders with different user teams associated to each folder with slightly difference dashboards in each folder. This change allows the team home dashboard to be selected by a specific folder rather than just picking the first dashboard that matches the name which might be the wrong dashboard in wrong folder and in my case would get permission denied for our users if wrong dashboard ended up matching the previous search logic that just looked for first dashboard to match a given name.