Accept Sensitive ldap_cfg
#282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to 04fcd91 this commit adds support for `Sensitive` to the `ldap_cfg` parameter. I've also fixed the LDAP examples `email` attibute to be `mail` which is correct for Active Directory (where `username` is `sAMAccountName`)
bastelfreak
reviewed
May 23, 2022
| @@ -137,7 +137,7 @@ | |||
| Optional[String] $archive_source, | |||
| String $cfg_location, | |||
| Variant[Hash,Sensitive[Hash]] $cfg, | |||
| Optional[Variant[Hash,Array]] $ldap_cfg, | |||
| Optional[Variant[Hash,Array[Hash],Sensitive[Hash],Sensitive[Array[Hash]]]] $ldap_cfg, | |||
There was a problem hiding this comment.
now thats a combination that could be put into ita own type with some tests
There was a problem hiding this comment.
Maybe if we ever get round to converting the docs to puppet-strings?? Tests are mainly useful for Pattern types IMO.
bastelfreak
approved these changes
May 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to 04fcd91 this commit adds
support for
Sensitiveto theldap_cfgparameter.I've also fixed the LDAP examples
emailattibute to bemailwhichis correct for Active Directory (where
usernameissAMAccountName)