Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Debian bookworm support #130

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

lbetz
Copy link
Contributor

@lbetz lbetz commented Jun 10, 2024

No description provided.

@lbetz lbetz added the bug Something isn't working label Jun 10, 2024
@lbetz lbetz added this to the v5.0.1 milestone Jun 10, 2024
@lbetz lbetz requested a review from bastelfreak June 10, 2024 15:17
Copy link
Member

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, but when adding support for new systems, we do minor version bumps (i.e. add functionality in a backward compatible manner) rather than a patch version bump (i.e. backward compatible bug fixes).

@lbetz
Copy link
Contributor Author

lbetz commented Jun 10, 2024

Wasn't new, Debian bookworm support added in 5.0.0. But forgot to add metadata file.

@smortex
Copy link
Member

smortex commented Jun 10, 2024

Ah, acceptance tests help to spot this 😉

Maybe we can start with a very basic one like this:

# frozen_string_literal: true

require 'spec_helper_acceptance'

describe 'incinga class' do
  it 'works idempotently with no errors' do
    pp = <<~MANIFEST
      class { 'incinga':
      }
    MANIFEST

    apply_manifest(pp, catch_failures: true)
    apply_manifest(pp, catch_changes: true)
  end
end

@lbetz lbetz added enhancement New feature or request and removed bug Something isn't working labels Jun 11, 2024
@lbetz lbetz changed the title Fix missing support of Debian bookworm Add Debian bookworm support Jun 11, 2024
@lbetz lbetz mentioned this pull request Jun 11, 2024
@lbetz
Copy link
Contributor Author

lbetz commented Jun 11, 2024

Fundamentally correct, we should do that. I removed the old vagrant base acceptence tests before moving to voxpupuli. But it's not quite that simple. This module primarily provides helper classes, such as icinga::repos for the three other Icinga modules or icinga::redis for the icingadb module. The main class icinga inside this module is also an private class used by icinga::agent, icinga::worker and icinga::server. All three of these are wrapper classes of the icinga2 class of module icinga2 and so on.

@lbetz lbetz removed the request for review from bastelfreak June 17, 2024 06:04
@lbetz lbetz merged commit 5fe08ef into voxpupuli:main Jun 17, 2024
4 checks passed
@lbetz lbetz deleted the bug/missing-support-debian-12 branch June 17, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants