-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Puppet 8 support #408
Add Puppet 8 support #408
Conversation
Hi @bastelfreak, since I am preparing the 5.2.0 release, does it make sense to merge some of the opened PR? |
|
None of the linked PRs have passing CI. This needs to be fixed before we continue. I currently don't have tue capacity to work on them. If you want, you can. pick those up, fix CI and resubmit them as new PRs. |
I see. I don't mind doing the work, but my knowledge about this is close to zero (and most of the CI logs have expired and are no longer available.) If there is something easy I can start with please let me know. About modulesync, actually for release I am preparing I rebased from your #394 because I couldn't wrap my head around the instructions in https://voxpupuli.org/docs/releasing_version/ The docs say "Run modulesync to ensure the dotfiles are up-to-date." but it does not explain how. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically LGTM, lets get this pipeline green
@bastelfreak with #414 this i obsolete. Is it ok to just close and delete the branch? |
e436f6c
to
35fb357
Compare
This isn't obsolete. The metadata.json currently doesn't list Puppet 8. |
No description provided.