Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Puppet 8 support #408

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Add Puppet 8 support #408

merged 2 commits into from
Feb 12, 2024

Conversation

bastelfreak
Copy link
Member

No description provided.

@bastelfreak bastelfreak added the enhancement New feature or request label Jul 2, 2023
@danifr
Copy link
Member

danifr commented Nov 6, 2023

Hi @bastelfreak, since I am preparing the 5.2.0 release, does it make sense to merge some of the opened PR?
We have some that are quite safe to merge

@bastelfreak
Copy link
Member Author

None of the linked PRs have passing CI. This needs to be fixed before we continue. I currently don't have tue capacity to work on them. If you want, you can. pick those up, fix CI and resubmit them as new PRs.

@danifr
Copy link
Member

danifr commented Nov 6, 2023

I see. I don't mind doing the work, but my knowledge about this is close to zero (and most of the CI logs have expired and are no longer available.)

If there is something easy I can start with please let me know.

About modulesync, actually for release I am preparing I rebased from your #394 because I couldn't wrap my head around the instructions in https://voxpupuli.org/docs/releasing_version/

The docs say "Run modulesync to ensure the dotfiles are up-to-date." but it does not explain how.

Thanks

Copy link
Sponsor Member

@SimonHoenscheid SimonHoenscheid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically LGTM, lets get this pipeline green

@h-haaks
Copy link
Contributor

h-haaks commented Feb 12, 2024

@bastelfreak with #414 this i obsolete. Is it ok to just close and delete the branch?

@bastelfreak
Copy link
Member Author

This isn't obsolete. The metadata.json currently doesn't list Puppet 8.

@bastelfreak bastelfreak merged commit 75170d0 into master Feb 12, 2024
16 checks passed
@bastelfreak bastelfreak deleted the puppet8_20230723 branch February 12, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants