Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporters unpacked to /opt are not root:root #111

Open
TomaszUrugOlszewski opened this issue Nov 16, 2017 · 1 comment · May be fixed by #602
Open

Exporters unpacked to /opt are not root:root #111

TomaszUrugOlszewski opened this issue Nov 16, 2017 · 1 comment · May be fixed by #602
Labels
enhancement New feature or request

Comments

@TomaszUrugOlszewski
Copy link

TomaszUrugOlszewski commented Nov 16, 2017 •
edited
Loading

Hello,

Most of exporters pulled from github after unpacking have owner/group different than root:root. In some specific cases non-root user can replace binary with malicious code, and run it with (sometimes, maybe) more permissions as exporter user. Or just fake diagnostic data, which can lead to other issues.
@bastelfreak
Copy link
Member

Hi @TomaszUrugOlszewski. thanks for rising this issue. Are you able to provide a patch for this? Should the user always be root or prometheus?

@tuxmea tuxmea added the enhancement New feature or request label Nov 16, 2017
slauger added a commit to slauger/puppet-prometheus that referenced this issue Jul 25, 2018
@slauger
manage base directory with recurse to fix owner/group permissions (vo…
a082a7e 
…xpupuli#111)
@ceriath ceriath linked a pull request Jan 7, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix file ownerships ceriath/puppet-prometheus
3 participants
@bastelfreak @tuxmea @TomaszUrugOlszewski