Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service resource in prometheus::daemon does not depend on init_style dependent service description #94

Closed
ghost opened this issue Oct 25, 2017 · 1 comment · Fixed by #95
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Oct 25, 2017

Affected Puppet, Ruby, OS and module versions/distributions

  • Puppet: 4.10
  • Ruby: 2.1.9
  • Distribution: CentOS 7
  • Module version: v2.0.0

How to reproduce (e.g Puppet code you use)

 include prometheus::node_exporter

What are you seeing

Notice: /Stage[main]/Prometheus::Node_exporter/Prometheus::Daemon[node_exporter]/Group[prometheus]/ensure: created
Notice: /Stage[main]/Prometheus::Node_exporter/Prometheus::Daemon[node_exporter]/User[prometheus]/ensure: created
Notice: /Stage[main]/Prometheus::Node_exporter/Prometheus::Daemon[node_exporter]/Package[prometheus-node-exporter]/ensure: created
Error: Systemd start for node_exporter failed!
journalctl log for node_exporter:
-- No entries --

Error: /Stage[main]/Prometheus::Node_exporter/Prometheus::Daemon[node_exporter]/Service[node_exporter]/ensure: change from stopped to running failed: Systemd start for node_exporter journalctl log for node_exporter:
-- No entries --
Notice: /Stage[main]/Prometheus::Node_exporter/Prometheus::Daemon[node_exporter]/Systemd::Unit_file[node_exporter.service]/File[/etc/systemd/system/node_exporter.service]/ensure: defined content as '{md5}b94d9aa7e7c105276490a5eebf37560b'
...

Note that the service was started before the unit file was created, resulting in an error.

What behaviour did you expect instead

The service is only started after the unit file has been created.

@tuxmea
Copy link
Member

tuxmea commented Oct 26, 2017

systemd and sysv case statetments in daemon.pp (line 170-182) don't have the notify parameter which is present at all other $init_style cases

tuxmea pushed a commit to tuxmea/puppet-prometheus that referenced this issue Oct 26, 2017
@tuxmea tuxmea added the bug Something isn't working label Oct 26, 2017
knackjax pushed a commit to knackjax/puppet-prometheus that referenced this issue Nov 21, 2017
cegeka-jenkins pushed a commit to cegeka/puppet-prometheus that referenced this issue Aug 28, 2019
Rovanion pushed a commit to Rovanion/puppet-prometheus that referenced this issue May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant