Add max_open_files parameter for systemd systems
#298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjfisher
force-pushed
the
max_file_descriptors
branch
from
7e974f7
to
f38bbda
Compare
|
@alexjfisher ping :) |
dhoppe
reviewed
Jun 5, 2019
| @@ -180,6 +185,7 @@ | |||
| Hash $config_defaults = {}, | |||
| String $os = downcase($facts['kernel']), | |||
| Optional[Variant[Stdlib::HTTPUrl, Stdlib::Unixpath, String[1]]] $external_url = undef, | |||
| Optional[Integer] $max_open_files = undef, | |||
There was a problem hiding this comment.
@alexjfisher Could you please fix the indentation?
There was a problem hiding this comment.
I didn't think adding 45 extra whitespaces improved readability.
There was a problem hiding this comment.
Rebased (which added the collect_scrape_jobs line above mine)
|
Ping @alexjfisher |
alexjfisher
force-pushed
the
max_file_descriptors
branch
from
f38bbda
to
d3e4fee
Compare
Rovanion
pushed a commit
to Rovanion/puppet-prometheus
that referenced
this pull request
May 5, 2021
Add `max_open_files` parameter for systemd systems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #297
@sc0rp10 Does this work for you?